arch/esp32_spi: Add check to see if the TX_FIFO is empty #15904
Conversation
to avoid sending empty data Signed-off-by: nuttxs <[email protected]>
github-actions
bot
added
Arch: xtensa
|
[Experimental Bot, please feedback here] Yes, this PR appears to meet the NuttX requirements, although the Testing section could be improved. While it specifies the target, it lacks specific build host information (OS, compiler, etc.) and, critically, it's missing the actual content of the testing logs before and after the change. Simply stating "ESP32 as SPI master device send data" isn't sufficient evidence of testing. The logs should demonstrate the erroneous behavior before the fix and the correct behavior afterward. |
acassis
requested review from
tmedicci,
btashton,
liuguo09,
adamfeuer,
anchao,
davids5,
cederom,
yf13,
pussuw,
raiden00pl,
jerpelea,
lupyuen,
pkarashchenko,
xiaoxiang781216,
johannes-nivus,
masayuki2009,
fjpanag,
GUIDINGLI,
hartmannathan and
Donny9
|
nuttx/arch/xtensa/src/esp32/esp32_spi.c Lines 948 to 951 in 03e8152 Just a minor comment: We seem to have a few variations of the Empty While Loop, wonder if we might wanna use the existing variations instead? Thanks :-) |
Summary
arch/esp32_spi: Add check to see if the TX_FIFO is empty to avoid sending empty data
Impact
New Feature/Change: Issue fix (no new feature).
User Impact: No
Build Impact:No new Kconfig options or build system changes.
Hardware Impact: Only ESP32; other architectures unaffected.
Security: No
Compatibility: Backward-compatible; no breaking changes.
Testing
ESP32-DevKitC, NuttX with SPI configurations, ESP32 as SPI master device send data.